This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
featured log #848
featured log #848
Changes from all commits
f80068f
50af2c6
ee766dd
d3b6bea
3b900a3
d5fb64e
9a4e628
4890b67
97e8757
4841835
c161964
5e3f131
acdd752
e8a68e3
cf97742
2b37f62
04c08ad
0bd2a78
7b62f9c
8d7ffe3
794f37b
a5e8ddf
5e99384
1df7977
17cf262
a152d98
c503d1c
09d59be
5830055
8ae764e
8b52f55
694fbe6
abd1341
10c9bb8
5a14323
95d2d9c
773ef0c
c19087d
27f3bae
4331dc6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment about the expected format to parse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we never follow any standard in messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will work on that in my next pr after this pr is merged. I have discussed with @nicolegys and decided to make the log system more test friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we'd better add a comment. @Liaojinghui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that it's all the same color, do we still need to parse the message?