-
Notifications
You must be signed in to change notification settings - Fork 224
Added blockchain show block/transactions/contracts commands #905
Added blockchain show block/transactions/contracts commands #905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it :)
My review:
print
orshow
?- Can you add
print
andshow
contract (by id, hash, or name if it's native)?
@cschuchardt88 Can we add application logs if the node supports them (e.g. state, notifications, etc)? It could be appended on |
@cschuchardt88 show has being used as a command to print things to the console, would be good to change to show. We can discuss whether to change from show to print in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@superboyiii could you test it?
I will |
@superboyiii can you make sure you can get blocks, transactions and contracts with all the attributes on them. |
I can't get |
Maybe it's better to support getting details of attribute, currently it only gets
And for conflict attribute, like
|
Agree, |
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Jimmy <jinghui@wayne.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me.
Change Log
show block <index>
show block <hash>
show tx <hash>
show contract <name>
show contract <hash>