This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Allow to compress syscalls api methods #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
approved these changes
Apr 8, 2019
igormcoelho
reviewed
Apr 8, 2019
| script.EmitSysCall("Neo.Runtime.GetTrigger", true); | ||
| CollectionAssert.AreEqual(new byte[] { (byte)OpCode.SYSCALL, 0x04, 0x75, 0xC8, 0x93, 0xE3 }.ToArray(), script.ToArray()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Good test here! But man, stop being lazy and add another test (with false) with the complete byte array (writing all bytes manually xD)
There was a problem hiding this comment.
I have 252 tests, 3 lines below, with false xD
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can build using the last version of
SYSCALL