Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Compressed BigInteger format #171

Closed
wants to merge 5 commits into from
Closed

Compressed BigInteger format #171

wants to merge 5 commits into from

Conversation

igormcoelho
Copy link
Contributor

closes #170

@igormcoelho
Copy link
Contributor Author

@shargon @vncoelho is it the same issue we had in neo-project/neo? I don't know why it's failing.

@igormcoelho igormcoelho mentioned this pull request Jun 13, 2019
Merged
@igormcoelho
Copy link
Contributor Author

We have another possibility here, perhaps better.

We rename PUSH0 to PUSHBYTES0. Its position is reasonable, because it comes before 0x01, which is PUSHBYTES1.
We create another opcode on empty position 0x50, which will be the "real" PUSH0. It comes just before PUSH1, which is also reasonable. What do you guys think?
After all, I think it's much better anyway, I'll start redoing the work...

@igormcoelho
Copy link
Contributor Author

It's too much work to redo hahahah I'll start again in another PR ;)

@igormcoelho igormcoelho deleted the feat_3x_std_integer branch June 13, 2019 15:20
@igormcoelho igormcoelho mentioned this pull request Jun 13, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikzhang erikzhang Awaiting requested review from erikzhang

@shargon shargon Awaiting requested review from shargon

@lightszero lightszero Awaiting requested review from lightszero

@vncoelho vncoelho Awaiting requested review from vncoelho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigInteger to Hex in most compressed format (NeoVM 3)
1 participant
@igormcoelho