Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

fix dos attack #458

Closed
wants to merge 3 commits into from
Closed

fix dos attack #458

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6bcc22
fix dos attack
Jim8y May 7, 2022
b64d29d
make the limitation price related.
Jim8y May 7, 2022
2e15218
fix ret=0
Jim8y May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 210 additions & 4 deletions src/neo-vm/ExecutionEngine.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ public class ExecutionEngine : IDisposable
{
private VMState state = VMState.BREAK;
private bool isJumping = false;
private uint[]? _maxOpCodes;


/// <summary>
/// Restrictions on the VM.
Expand Down Expand Up @@ -68,10 +70,7 @@ public class ExecutionEngine : IDisposable
/// </summary>
public VMState State
{
get
{
return state;
}
get => state;
internal protected set
{
if (state != value)
Expand Down Expand Up @@ -151,6 +150,7 @@ private void ExecuteCall(int position)
private void ExecuteInstruction()
{
Instruction instruction = CurrentContext!.CurrentInstruction;
CheckOpCode(instruction.OpCode);
switch (instruction.OpCode)
{
//Push
Expand Down Expand Up @@ -1677,5 +1677,211 @@ public void Push(StackItem item)
{
CurrentContext!.EvaluationStack.Push(item);
}

private void CheckOpCode(OpCode opCode)
{
if (_maxOpCodes == null)
{
_maxOpCodes = new uint[byte.MaxValue];
Array.Clear(_maxOpCodes, 0, _maxOpCodes.Length);
}
_maxOpCodes[(byte)opCode]++;
if (_maxOpCodes[(byte)opCode] > 1024 * 1024 / (OpCodePrices[opCode] == 0 ? 1 : OpCodePrices[opCode]))
throw new InvalidOperationException($"MaxOpCodeSize exceed: {ReferenceCounter.Count}");
}

private static readonly IReadOnlyDictionary<OpCode, long> OpCodePrices = new Dictionary<OpCode, long>
{
[OpCode.PUSHINT8] = 1 << 0,
[OpCode.PUSHINT16] = 1 << 0,
[OpCode.PUSHINT32] = 1 << 0,
[OpCode.PUSHINT64] = 1 << 0,
[OpCode.PUSHINT128] = 1 << 2,
[OpCode.PUSHINT256] = 1 << 2,
[OpCode.PUSHA] = 1 << 2,
[OpCode.PUSHNULL] = 1 << 0,
[OpCode.PUSHDATA1] = 1 << 3,
[OpCode.PUSHDATA2] = 1 << 9,
[OpCode.PUSHDATA4] = 1 << 12,
[OpCode.PUSHM1] = 1 << 0,
[OpCode.PUSH0] = 1 << 0,
[OpCode.PUSH1] = 1 << 0,
[OpCode.PUSH2] = 1 << 0,
[OpCode.PUSH3] = 1 << 0,
[OpCode.PUSH4] = 1 << 0,
[OpCode.PUSH5] = 1 << 0,
[OpCode.PUSH6] = 1 << 0,
[OpCode.PUSH7] = 1 << 0,
[OpCode.PUSH8] = 1 << 0,
[OpCode.PUSH9] = 1 << 0,
[OpCode.PUSH10] = 1 << 0,
[OpCode.PUSH11] = 1 << 0,
[OpCode.PUSH12] = 1 << 0,
[OpCode.PUSH13] = 1 << 0,
[OpCode.PUSH14] = 1 << 0,
[OpCode.PUSH15] = 1 << 0,
[OpCode.PUSH16] = 1 << 0,
[OpCode.NOP] = 1 << 0,
[OpCode.JMP] = 1 << 1,
[OpCode.JMP_L] = 1 << 1,
[OpCode.JMPIF] = 1 << 1,
[OpCode.JMPIF_L] = 1 << 1,
[OpCode.JMPIFNOT] = 1 << 1,
[OpCode.JMPIFNOT_L] = 1 << 1,
[OpCode.JMPEQ] = 1 << 1,
[OpCode.JMPEQ_L] = 1 << 1,
[OpCode.JMPNE] = 1 << 1,
[OpCode.JMPNE_L] = 1 << 1,
[OpCode.JMPGT] = 1 << 1,
[OpCode.JMPGT_L] = 1 << 1,
[OpCode.JMPGE] = 1 << 1,
[OpCode.JMPGE_L] = 1 << 1,
[OpCode.JMPLT] = 1 << 1,
[OpCode.JMPLT_L] = 1 << 1,
[OpCode.JMPLE] = 1 << 1,
[OpCode.JMPLE_L] = 1 << 1,
[OpCode.CALL] = 1 << 9,
[OpCode.CALL_L] = 1 << 9,
[OpCode.CALLA] = 1 << 9,
[OpCode.CALLT] = 1 << 15,
[OpCode.ABORT] = 0,
[OpCode.ASSERT] = 1 << 0,
[OpCode.THROW] = 1 << 9,
[OpCode.TRY] = 1 << 2,
[OpCode.TRY_L] = 1 << 2,
[OpCode.ENDTRY] = 1 << 2,
[OpCode.ENDTRY_L] = 1 << 2,
[OpCode.ENDFINALLY] = 1 << 2,
[OpCode.RET] = 0,
[OpCode.SYSCALL] = 0,
[OpCode.DEPTH] = 1 << 1,
[OpCode.DROP] = 1 << 1,
[OpCode.NIP] = 1 << 1,
[OpCode.XDROP] = 1 << 4,
[OpCode.CLEAR] = 1 << 4,
[OpCode.DUP] = 1 << 1,
[OpCode.OVER] = 1 << 1,
[OpCode.PICK] = 1 << 1,
[OpCode.TUCK] = 1 << 1,
[OpCode.SWAP] = 1 << 1,
[OpCode.ROT] = 1 << 1,
[OpCode.ROLL] = 1 << 4,
[OpCode.REVERSE3] = 1 << 1,
[OpCode.REVERSE4] = 1 << 1,
[OpCode.REVERSEN] = 1 << 4,
[OpCode.INITSSLOT] = 1 << 4,
[OpCode.INITSLOT] = 1 << 6,
[OpCode.LDSFLD0] = 1 << 1,
[OpCode.LDSFLD1] = 1 << 1,
[OpCode.LDSFLD2] = 1 << 1,
[OpCode.LDSFLD3] = 1 << 1,
[OpCode.LDSFLD4] = 1 << 1,
[OpCode.LDSFLD5] = 1 << 1,
[OpCode.LDSFLD6] = 1 << 1,
[OpCode.LDSFLD] = 1 << 1,
[OpCode.STSFLD0] = 1 << 1,
[OpCode.STSFLD1] = 1 << 1,
[OpCode.STSFLD2] = 1 << 1,
[OpCode.STSFLD3] = 1 << 1,
[OpCode.STSFLD4] = 1 << 1,
[OpCode.STSFLD5] = 1 << 1,
[OpCode.STSFLD6] = 1 << 1,
[OpCode.STSFLD] = 1 << 1,
[OpCode.LDLOC0] = 1 << 1,
[OpCode.LDLOC1] = 1 << 1,
[OpCode.LDLOC2] = 1 << 1,
[OpCode.LDLOC3] = 1 << 1,
[OpCode.LDLOC4] = 1 << 1,
[OpCode.LDLOC5] = 1 << 1,
[OpCode.LDLOC6] = 1 << 1,
[OpCode.LDLOC] = 1 << 1,
[OpCode.STLOC0] = 1 << 1,
[OpCode.STLOC1] = 1 << 1,
[OpCode.STLOC2] = 1 << 1,
[OpCode.STLOC3] = 1 << 1,
[OpCode.STLOC4] = 1 << 1,
[OpCode.STLOC5] = 1 << 1,
[OpCode.STLOC6] = 1 << 1,
[OpCode.STLOC] = 1 << 1,
[OpCode.LDARG0] = 1 << 1,
[OpCode.LDARG1] = 1 << 1,
[OpCode.LDARG2] = 1 << 1,
[OpCode.LDARG3] = 1 << 1,
[OpCode.LDARG4] = 1 << 1,
[OpCode.LDARG5] = 1 << 1,
[OpCode.LDARG6] = 1 << 1,
[OpCode.LDARG] = 1 << 1,
[OpCode.STARG0] = 1 << 1,
[OpCode.STARG1] = 1 << 1,
[OpCode.STARG2] = 1 << 1,
[OpCode.STARG3] = 1 << 1,
[OpCode.STARG4] = 1 << 1,
[OpCode.STARG5] = 1 << 1,
[OpCode.STARG6] = 1 << 1,
[OpCode.STARG] = 1 << 1,
[OpCode.NEWBUFFER] = 1 << 8,
[OpCode.MEMCPY] = 1 << 11,
[OpCode.CAT] = 1 << 11,
[OpCode.SUBSTR] = 1 << 11,
[OpCode.LEFT] = 1 << 11,
[OpCode.RIGHT] = 1 << 11,
[OpCode.INVERT] = 1 << 2,
[OpCode.AND] = 1 << 3,
[OpCode.OR] = 1 << 3,
[OpCode.XOR] = 1 << 3,
[OpCode.EQUAL] = 1 << 5,
[OpCode.NOTEQUAL] = 1 << 5,
[OpCode.SIGN] = 1 << 2,
[OpCode.ABS] = 1 << 2,
[OpCode.NEGATE] = 1 << 2,
[OpCode.INC] = 1 << 2,
[OpCode.DEC] = 1 << 2,
[OpCode.ADD] = 1 << 3,
[OpCode.SUB] = 1 << 3,
[OpCode.MUL] = 1 << 3,
[OpCode.DIV] = 1 << 3,
[OpCode.MOD] = 1 << 3,
[OpCode.POW] = 1 << 6,
[OpCode.SQRT] = 1 << 6,
[OpCode.SHL] = 1 << 3,
[OpCode.SHR] = 1 << 3,
[OpCode.NOT] = 1 << 2,
[OpCode.BOOLAND] = 1 << 3,
[OpCode.BOOLOR] = 1 << 3,
[OpCode.NZ] = 1 << 2,
[OpCode.NUMEQUAL] = 1 << 3,
[OpCode.NUMNOTEQUAL] = 1 << 3,
[OpCode.LT] = 1 << 3,
[OpCode.LE] = 1 << 3,
[OpCode.GT] = 1 << 3,
[OpCode.GE] = 1 << 3,
[OpCode.MIN] = 1 << 3,
[OpCode.MAX] = 1 << 3,
[OpCode.WITHIN] = 1 << 3,
[OpCode.PACKMAP] = 1 << 11,
[OpCode.PACKSTRUCT] = 1 << 11,
[OpCode.PACK] = 1 << 11,
[OpCode.UNPACK] = 1 << 11,
[OpCode.NEWARRAY0] = 1 << 4,
[OpCode.NEWARRAY] = 1 << 9,
[OpCode.NEWARRAY_T] = 1 << 9,
[OpCode.NEWSTRUCT0] = 1 << 4,
[OpCode.NEWSTRUCT] = 1 << 9,
[OpCode.NEWMAP] = 1 << 3,
[OpCode.SIZE] = 1 << 2,
[OpCode.HASKEY] = 1 << 6,
[OpCode.KEYS] = 1 << 4,
[OpCode.VALUES] = 1 << 13,
[OpCode.PICKITEM] = 1 << 6,
[OpCode.APPEND] = 1 << 13,
[OpCode.SETITEM] = 1 << 13,
[OpCode.REVERSEITEMS] = 1 << 13,
[OpCode.REMOVE] = 1 << 4,
[OpCode.CLEARITEMS] = 1 << 4,
[OpCode.POPITEM] = 1 << 4,
[OpCode.ISNULL] = 1 << 1,
[OpCode.ISTYPE] = 1 << 1,
[OpCode.CONVERT] = 1 << 13,
};
}
}