This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Add SafeReadBytes from VM #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A strict limit of 16MB was imposed (0x100000), that looks good enough for practice (better than GB...). Do you think we can validate this to see if it causes conflicts? @vncoelho @erikzhang @shargon @PeterLinX |
|
With the storage history we could sync and see any difference, but it would be better with a Merkle Tree. |
|
What's the difference between this and the old implemention? |
shargon
reviewed
Dec 10, 2018
src/neo-vm/Helper.cs
Outdated
|
|
||
| public static ulong ReadVarInt(this BinaryReader reader, ulong max = ulong.MaxValue) | ||
| { | ||
| byte fb = reader.ReadByte(); |
src/neo-vm/Helper.cs
Outdated
| value = fb; | ||
| if (value > max) throw new FormatException(); | ||
| return value; | ||
| if((max > 0x1000000) || (!reader.BaseStream.CanSeek) || (reader.BaseStream.Length - reader.BaseStream.Position) < max)) |
There was a problem hiding this comment.
If we want to throw an exception, then is not needed to check CanSeek, because this could throw an exception when you access to length in wrong streams
shargon
suggested changes
Dec 10, 2018
This was referenced Jan 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe ReadVarBytes is not necessary for NeoVM, and it's even misleading now that its limits on NeoVM (int max = 0X7fffffc7) differ from Neo limits of the "same" function (int max = 0x1000000).
ReadVarInt was also duplicated, so it was removed too.
A new function called SafeReadBytes (inspired by @shargon discussion neo-project/neo#511) was added, and it can be reused inside Neo project if necessary.