Proposal of VM-UT

[shargon]

• Added 2 json

I will add more json here if we decide that this is the right way

[igormcoelho]

Will review asap @shargon, congratulations for the initiative!

[shargon]

@erikzhang ,BREAK state should be only when hit a breakpoint?

[igormcoelho]

@shargon I noticed you ported cryptography basics to NeoVM. Can we remove all this code and rely only on native C# implementation?

P.S.: I couldn't take enough time to review it in details yet, but I'm loving the idea of having JSON basis for tests... this is exactly what we need to achieve cross-compatibility between vm implementations. 1 thousand congratulations for you, for the nice idea!

[erikzhang]

BREAK state should be only when hit a breakpoint?

StepInto(), StepOut(), StepOver() or hitting a breakpoint.

[shargon]

@igormcoelho i know, i don't like too, but the other way is include neo package, and this package have neo-vm dependency... the solution should move this code to other project or to neo-vm, so i copy this code to test :P

[igormcoelho]

We can remove this Neo.Test.Cryptography include, since it looks like only RIPEMD160Managed is included, right?
I checked the implementation of RIPEMD160Managed and it is equivalent to the standard one in System.Security.Cryptography. So, we can use standard, the same way we do for SHA256.

Looks like ECC code pushed here is on Neo.Cryptography.ECC namespace, which is also not imported anywhere. So it can also be safely removed.

[igormcoelho]

Just found it... you recreated Crypto lib too...

Ok then. Let's approve this first, then we decide how to deal with this.

[shargon]

https://docs.microsoft.com/en-us/dotnet/api/system.security.cryptography.ripemd160managed?view=netframework-4.7.2 is not included in dotnet core :(

[igormcoelho]

oh, I didn't know that... O.o ok, one more reason to leave that for now. In the future we come back to this discussion.