Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

More unit tests #81

Merged
merged 17 commits into from
Mar 7, 2019
Merged

More unit tests #81

merged 17 commits into from
Mar 7, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Mar 6, 2019 •
edited
Loading

Added:

  • PUSHBYTES2 to PUSHBYTES74
  • SYSCALL
  • ARRAYSIZE
  • LEFT
  • RIGHT

erikzhang
erikzhang previously approved these changes Mar 6, 2019
View reviewed changes
@erikzhang
Copy link
Member

When you are ready, please merge it by yourself.

@shargon
Copy link
Member Author

shargon commented Mar 6, 2019

@erikzhang RIGHT set the state to Fault if exceed the string length, but LEFT don't, is this correct?

@erikzhang
Copy link
Member

RIGHT set the state to Fault if exceed the string length, but LEFT don't, is this correct?

Yes.

@shargon
Copy link
Member Author

shargon commented Mar 7, 2019 •
edited
Loading

We can merge this now, and i will make more UT in other PR.

@erikzhang erikzhang merged commit 8dd5a1f into neo-project:master Mar 7, 2019
@shargon shargon deleted the more-unit-tests branch March 7, 2019 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shargon @erikzhang