deny blocks with duplicate transactions

neo-project · Nov 2, 2018 · 6ff2b9a · 6ff2b9a
1 parent a64ca72
commit 6ff2b9a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/neo/Network/P2P/Payloads/Block.cs b/neo/Network/P2P/Payloads/Block.cs
@@ -53,6 +53,7 @@ public override void Deserialize(BinaryReader reader)
             base.Deserialize(reader);
             Transactions = new Transaction[reader.ReadVarInt(0x10000)];
             if (Transactions.Length == 0) throw new FormatException();
+            HashSet<UInt256> hashes = new HashSet<UInt256>();
             for (int i = 0; i < Transactions.Length; i++)
             {
                 Transactions[i] = Transaction.DeserializeFrom(reader);
@@ -66,6 +67,8 @@ public override void Deserialize(BinaryReader reader)
                     if (Transactions[i].Type == TransactionType.MinerTransaction)
                         throw new FormatException();
                 }
+                if (!hashes.Add(Transactions[i].Hash))
+                    throw new FormatException();
             }
             if (MerkleTree.ComputeRoot(Transactions.Select(p => p.Hash).ToArray()) != MerkleRoot)
                 throw new FormatException();