Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move transaction verification to RemoteNode #1479

Closed
Tommo-L opened this issue Mar 17, 2020 · 2 comments · Fixed by #1507
Closed

Move transaction verification to RemoteNode #1479

Tommo-L opened this issue Mar 17, 2020 · 2 comments · Fixed by #1507
Labels
discussion Initial issue state - proposed but not yet accepted

Comments

@Tommo-L
Copy link
Contributor

Tommo-L commented Mar 17, 2020 •
edited
Loading

Summary or problem description

Since we have removed parallel verification, after that it degrades our performance. As discussed earlier, we need to move transaction verification to RemoteNode for improving performance.

Neo Version

  • Neo 3

Where in the software does this update applies to?

  • P2P (TCP)
@Tommo-L Tommo-L added the discussion Initial issue state - proposed but not yet accepted label Mar 17, 2020
@shargon
Copy link
Member

shargon commented Mar 17, 2020

I think that we can have the same issues using different nodes.

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Mar 17, 2020

Maybe we should have a try?

@Qiao-Jin Qiao-Jin mentioned this issue Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relocate transaction verification Qiao-Jin/neo
2 participants
@shargon @Tommo-L