Relocate transaction verification #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from master
Merge from master
Merge from neo master
Limit the max height for some SYSCALLs (neo-project#1494)
vncoelho
reviewed
Mar 24, 2020
Tommo-L
reviewed
Mar 24, 2020
|
I think that this will produce the same behaviour than parallel verification, but hard to test it because we will need more nodes. |
…m/Qiao-Jin/neo into relocate_transaction_verification
Have seperate sender fee check from transaction verication and thus avoid unsafe situation, plz have a check:) |
vncoelho
reviewed
Mar 30, 2020
Tommo-L
reviewed
Apr 3, 2020
Tommo-L
reviewed
Apr 8, 2020
erikzhang
reviewed
Aug 13, 2020
|
The same transactions from different nodes will be verified multiple times? |
I think it's acceptable. If one arrives first, it will enter the mempool, and the next same tx will be filtered. |
shargon
reviewed
Aug 13, 2020
erikzhang
approved these changes
Aug 14, 2020
shargon
reviewed
Aug 14, 2020
|
@Qiao-Jin Can you review my changes? |
shargon
approved these changes
Aug 16, 2020
45 tasks
5 tasks
5 tasks
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Jan 15, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLose #1479