Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle contract doesn't implement NEP-17 onPayment method #2093

Closed
roman-khimov opened this issue Nov 23, 2020 · 0 comments · Fixed by #2098
Closed

Oracle contract doesn't implement NEP-17 onPayment method #2093

roman-khimov opened this issue Nov 23, 2020 · 0 comments · Fixed by #2098

Comments

@roman-khimov
Copy link
Contributor

Describe the bug
Oracle contract mints some GAS in its request method which in turns invokes onPayment on Oracle contract which just doesn't exist at the moment, so the call fails.

Expected behavior
Oracle requests should work, thus onPayment needs to be implemented in Oracle contract. I think we need to check for token type inside and only accept GAS (make transfers of any other tokens fail).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@roman-khimov