Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling native contracts' onPayment #2095

Closed
wants to merge 1 commit into from
Closed

Avoid calling native contracts' onPayment #2095

wants to merge 1 commit into from

Conversation

erikzhang
Copy link
Member

Fix #2093

@erikzhang
Copy link
Member Author

@roman-khimov

@Tommo-L Tommo-L mentioned this pull request Nov 24, 2020
Closed
@roman-khimov
Copy link
Contributor

@Tommo-L: actually, #2094 looks a little better to me. I'd rather not make native contracts special wrt this, first of all because native/non-native contracts should be treated equal as much as possible and second because non-native contracts couldn't do the same thing as here. And I'd also like to use onPayment in #1573 native contract which is impossible after this change.

@shargon
Copy link
Member

shargon commented Nov 24, 2020

Agree with @roman-khimov

@erikzhang erikzhang closed this Nov 24, 2020
@erikzhang erikzhang deleted the fixes/nep17-onpayment branch November 24, 2020 08:24
@roman-khimov roman-khimov mentioned this pull request Nov 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle contract doesn't implement NEP-17 onPayment method
3 participants
@erikzhang @roman-khimov @shargon