Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New designated role: P2P Notary #2895

Closed
roman-khimov opened this issue Sep 6, 2023 · 0 comments · Fixed by #3172
Closed

New designated role: P2P Notary #2895

roman-khimov opened this issue Sep 6, 2023 · 0 comments · Fixed by #3172
Labels
Discussion Initial issue state - proposed but not yet accepted
Milestone
v3.7.0

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
Add a new supported role number (32) to the RoleManagement contract, "P2PNotary", as per #1573 (comment)

Do you have any solution you want to propose?
Change 5 lines of the code and let this role exist.

Target Neo Version

  • Neo 3.7

Where in the software does this update applies to?

  • Native contracts
@roman-khimov roman-khimov added the Discussion Initial issue state - proposed but not yet accepted label Sep 6, 2023
@roman-khimov roman-khimov mentioned this issue Sep 6, 2023
Open
@roman-khimov roman-khimov mentioned this issue Sep 14, 2023
Closed
@AnnaShaleva AnnaShaleva mentioned this issue Nov 8, 2023
Closed
@roman-khimov roman-khimov added this to the v3.7.0 milestone Nov 16, 2023
AnnaShaleva added a commit to AnnaShaleva/neo that referenced this issue Mar 3, 2024
@AnnaShaleva
Add P2PNotary node role for native RoleManagement contract
ef23f5d 
Close neo-project#2895.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This was referenced Mar 3, 2024
Merged
Open
shargon added a commit that referenced this issue Mar 3, 2024
@AnnaShaleva @shargon
Add P2PNotary node role for native RoleManagement contract (#3172)
74562d5 
* Add P2PNotary node role for native RoleManagement contract

Close #2895.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Squash TestDesignateP2PNotary and TestGetSet of native RoleManagement

Extend TestGetSet to check designation of all node roles, including
P2PNotary role. TestDesignatedP2PNotary is not needed anymore.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

---------

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging a pull request may close this issue.

Add P2PNotary node role for native RoleManagement contract AnnaShaleva/neo
1 participant
@roman-khimov