-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New designated role: P2P Notary #2895
Labels
discussion
Initial issue state - proposed but not yet accepted
Milestone
Comments
roman-khimov
added
the
discussion
Initial issue state - proposed but not yet accepted
label
Sep 6, 2023
Closed
Closed
AnnaShaleva
added a commit
to AnnaShaleva/neo
that referenced
this issue
Mar 3, 2024
Close neo-project#2895. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
This was referenced Mar 3, 2024
shargon
added a commit
that referenced
this issue
Mar 3, 2024
* Add P2PNotary node role for native RoleManagement contract Close #2895. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> * Squash TestDesignateP2PNotary and TestGetSet of native RoleManagement Extend TestGetSet to check designation of all node roles, including P2PNotary role. TestDesignatedP2PNotary is not needed anymore. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> --------- Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru> Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary or problem description
Add a new supported role number (32) to the RoleManagement contract, "P2PNotary", as per #1573 (comment)
Do you have any solution you want to propose?
Change 5 lines of the code and let this role exist.
Target Neo Version
Where in the software does this update applies to?
The text was updated successfully, but these errors were encountered: