Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease block time to 5 sec #375

Closed
lerider opened this issue Sep 12, 2018 · 15 comments
Closed

Decrease block time to 5 sec #375

lerider opened this issue Sep 12, 2018 · 15 comments
Labels
Consensus Module - Changes that affect the consensus protocol or internal verification logic Design Issue state - Feature accepted but the solution requires a design before being implemented Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. Ledger Module - The ledger is our 'database', this is used to tag changes about how we store information

Comments

@lerider
Copy link

lerider commented Sep 12, 2018

With finality in every block, faster blocks can produce a vast increase of utility in terms of settlement.

Suggestion is to decrease block time to 5 seconds and decrease GAS release by a factor of 3 (~3 blocks in 15 sec, so GAS release should be divided by three).

At later stage, we can evaluate the impact of faster blocks and potentially reduce to 1-2 second blocks.

This is a discussion.

@erikzhang erikzhang added the Discussion Initial issue state - proposed but not yet accepted label Sep 12, 2018
@erikzhang erikzhang added this to the NEO 3.0 milestone Sep 12, 2018
@shargon
Copy link
Member

shargon commented Sep 12, 2018

The first impact is the size, the chain will grow faster (when there are no transactions), if the size is not a problem, we need to ensure that the TX in the block is ordered by received date too (for ensure that is more spread around the network)

@igormcoelho
Copy link
Contributor

igormcoelho commented Sep 13, 2018

I agree that time must be reduced to achieve the expected 100k TPS... I think we could do some experimentation in a near future to diagnose what could be the best timing given the current implementation. In fact, this calibration analysis is supposed to be a part of the consensus competition that we are planning to launch soon enough :)

@EdgeDLT
Copy link

EdgeDLT commented Sep 13, 2018

Would love to see 5 second blocks given the TPS improvements (not to mention it'll really demonstrate the power of same-block finality), but I have a few questions:

  • How realistic is maintaining 5 second blocks as the number of consensus nodes increases?
  • Are we relying on Akka alone to resolve our issues with large blocks causing delayed block times, or are there other solutions that can help provide consistency?
  • What about chain size/sync time for nodes?

@shargon
Copy link
Member

shargon commented Sep 14, 2018

If we have 5 seconds, we should reduce the MaxSizeBlock

@toghrulmaharram
Copy link

toghrulmaharram commented Sep 14, 2018

It is unlikely that we would be able to produce 5 second blocks as the network grows and the second agreement phase is added to the protocol (the COMMIT phase). Bare in mind that the more nodes join the network, the less eventual throughput the network can achieve.

@canesin
Copy link
Contributor

canesin commented Oct 13, 2018

There is no technical need to reduce block time, as a matter of fact it could be increased. One can do risk management by observing state of a target transaction in the network and instantaneously accept low risk transactions. One can confirm <1s txs with this method.

NEX for example is implementing this technology in its payment processing offerings.

The advantage of keeping (or increasing) block time are many: lower size of blockchain, lower communication bottleneck, improve consensus efficiency.

@lllwvlvwlll
Copy link
Member

lllwvlvwlll commented Oct 13, 2018 via email

@vncoelho
Copy link
Member

vncoelho commented Apr 9, 2019

Hi @lerider, my friend.
Let's reactivate this discussion 🗡️

Bow with the success of dBFT 2.0 we gonna be able to discuss and test this in the future months.

@lerider
Copy link
Author

lerider commented Apr 10, 2019

Now I want to see 1 second blocks, go for it!

@lock9
Copy link
Contributor

lock9 commented Jul 16, 2019

@neo-project/core so, this has a NEO 3 milestone, is there anything that should be done before this is implemented?

@vncoelho
Copy link
Member

I think it is almost ready for that, @lock9:

  • We would need to adjust GAS generation formula.

We have been discussing other crazy ideas, such just generating blocks with transactions. ahuehaueaea

But I think that reduce block time to 5s might be good, in particular, because we have block finality and it would maker experience of the Ecosystem even better.

@lock9
Copy link
Contributor

lock9 commented Jul 16, 2019

This can work, as long as we avoid generating empty blocks every 5 seconds.

@EdgeDLT
Copy link

EdgeDLT commented Jul 16, 2019

As much as I think 5 second blocks with finality would be awesome, maybe 10 seconds would be a better place to start for NEO3?

We don't want to run into a situation where 5 second blocks are stable with 7 nodes but start having problems as the total number of nodes increases.

@lock9 lock9 added Consensus Module - Changes that affect the consensus protocol or internal verification logic Design Issue state - Feature accepted but the solution requires a design before being implemented Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. Ledger Module - The ledger is our 'database', this is used to tag changes about how we store information and removed Discussion Initial issue state - proposed but not yet accepted labels Aug 12, 2019
@shargon
Copy link
Member

shargon commented Nov 21, 2019

maybe 10 seconds would be a better place to start for NEO3?

I think that 10 seconds is a very good time for NEO 3. At least for the testnet, and after some time, we can study the testnet and take the right decision.

@lllwvlvwlll
Copy link
Member

Has there been any testing on privatenets to evaluate whether this will have a noticeable performance impact? It does not seem like a good idea to change this without any empirical data.

At some point, the network and block processing overhead is going to overtake the benefit from increased minting frequency. Additionally, this critical point will change as the network load changes (longer block times are more efficient with large transaction volume). Has there been any investigation into variable block times? It was discussed at the shanghai meetup and I believe that would potentially give us the best of both worlds.

@erikzhang erikzhang removed this from the NEO 3.0 milestone Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Consensus Module - Changes that affect the consensus protocol or internal verification logic Design Issue state - Feature accepted but the solution requires a design before being implemented Enhancement Type - Changes that may affect performance, usability or add new features to existing modules. Ledger Module - The ledger is our 'database', this is used to tag changes about how we store information
Projects
None yet
Development

No branches or pull requests

10 participants