Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid processing own hashes (3x) #1009

Merged
merged 5 commits into from
Aug 11, 2019
Merged

Avoid processing own hashes (3x) #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac43d76
Avoid processing own hashes
vncoelho Aug 8, 2019
8351e9f
Shargon's suggestion I
vncoelho Aug 8, 2019
85bf8b9
Shargon's suggestion II
vncoelho Aug 8, 2019
a53fdc4
rename
erikzhang Aug 9, 2019
e60d057
Merge branch 'master' into avoiding-processing-own-hashes
shargon Aug 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions neo/IO/Caching/FIFOSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ public bool Add(T item)
return true;
}

public bool Contains(T item)
{
return dictionary.Contains(item);
}

public void ExceptWith(IEnumerable<UInt256> hashes)
{
foreach (var hash in hashes)
Expand Down
2 changes: 1 addition & 1 deletion neo/Network/P2P/ProtocolHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ private void OnInventoryReceived(IInventory inventory)

private void OnInvMessageReceived(InvPayload payload)
{
UInt256[] hashes = payload.Hashes.Where(p => knownHashes.Add(p)).ToArray();
UInt256[] hashes = payload.Hashes.Where(p => knownHashes.Add(p) && !sentHashes.Contains(p)).ToArray();
if (hashes.Length == 0) return;
switch (payload.Type)
{
Expand Down