Fix the potential risk to get null CurrentHeaderHash from Blockchain (2x) #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the difference? |
yongjiema
changed the title
Before: Reading without lock may get null value from a changeable collection in case of multiple reading, please check https://stackoverflow.com/questions/17769892/c-sharp-multi-threaded-queue-items-are-null for more details. After: The Interlocked.Exchange is an atomic operation which is friendly for multithreading (https://github.com/neo-project/neo/blob/master-2.x/neo/Ledger/Blockchain.cs#L729). PS: I've encountered the issue on my local node. |
erikzhang
approved these changes
Aug 15, 2019
shargon
approved these changes
Aug 15, 2019
vncoelho
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
Tested and working normally. I did not reproduce the fix, but makes sense.
Nice job you are doing @yongjiema, let's port this to 3x, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.