Read only methods #1049
Closed
Read only methods #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
commented
Aug 22, 2019
| ContractManifest currentManifest = engine.Snapshot.Contracts.TryGet(engine.CurrentScriptHash)?.Manifest; | ||
|
|
||
| if (currentManifest != null && !currentManifest.CanCall(contract.Manifest, method.GetString())) | ||
| if (currentManifest != null && !currentManifest.CanCall(contract.Manifest, methodStr)) |
There was a problem hiding this comment.
@neo-project/core @erikzhang current Manifest could be null? i think that it is a MUST
Suggested change
| if (currentManifest != null && !currentManifest.CanCall(contract.Manifest, methodStr)) | |
| if (currentManifest == null || !currentManifest.CanCall(contract.Manifest, methodStr)) |
shargon
commented
Aug 22, 2019
| public static readonly uint System_Contract_Destroy = Register("System.Contract.Destroy", Contract_Destroy, 0_01000000, TriggerType.Application); | ||
| public static readonly uint System_Storage_GetContext = Register("System.Storage.GetContext", Storage_GetContext, 0_00000400, TriggerType.Application); | ||
| public static readonly uint System_Contract_Destroy = Register("System.Contract.Destroy", Contract_Destroy, 0_01000000, TriggerType.Application, true); | ||
| public static readonly uint System_Storage_GetContext = Register("System.Storage.GetContext", Storage_GetContext, 0_00000400, TriggerType.Application, true); |
There was a problem hiding this comment.
@igormcoelho I increased the scope not only for the storages, for destroy, update, and create too
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
+ Coverage 61.34% 61.35% +0.01%
==========================================
Files 195 196 +1
Lines 13407 13414 +7
==========================================
+ Hits 8224 8230 +6
- Misses 5183 5184 +1
Continue to review full report at Codecov.
|
* Update VM to last changes * Remove hashes
This was referenced Aug 23, 2019
|
Wrong rebased, closed in favor of #1052 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #927
TODO: