Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PublishTransaction deserialization (2x) #1235

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Fix PublishTransaction deserialization (2x) #1235

merged 3 commits into from
Nov 14, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 12, 2019

No description provided.

@shargon shargon added the Bug Used to tag confirmed bugs label Nov 12, 2019
lock9
lock9 reviewed Nov 12, 2019
View reviewed changes
Copy link
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change anything? Isn’t this transaction deprecated? Why this problem appeared only now?

@shargon
Copy link
Member Author

shargon commented Nov 12, 2019 •
edited
Loading

Is deprecated, but I think that it should be fixed because maybe you can relay it and invoke the deserialization

@lock9
Copy link
Contributor

lock9 commented Nov 12, 2019

But won’t verification fail?

lock9
lock9 previously requested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UT? 😅

@shargon shargon requested a review from lock9 November 13, 2019 12:23
@lock9 lock9 merged commit 1e0ee13 into neo-project:master-2.x Nov 14, 2019
@shargon shargon deleted the fix-publish-tx branch November 14, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lock9 lock9 lock9 approved these changes

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
Bug Used to tag confirmed bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shargon @lock9 @erikzhang