Moving rpc to plugin #1290
Moving rpc to plugin #1290
Conversation
|
We can't help. You need a rebase. |
melanke
force-pushed
the
moving-rpc-to-plugin
branch
from
3fff2a9
to
90f0a3b
Compare
done |
|
I don't understand why we need these |
|
@erikzhang is to improve the usability of HttpServer controller, you will be able to receive and return primitive types instead of having to transform from/to JObject inside the RPC/Rest method. But it is useful for many situations, not only on this case. I can't do this using extension methods because I need to overload the method. |
melanke
force-pushed
the
moving-rpc-to-plugin
branch
4 times, most recently
from
61dede1
to
14dd15b
Compare
melanke
force-pushed
the
moving-rpc-to-plugin
branch
from
702dba5
to
1049ada
Compare
|
Are this changes good? May I change all plugins depending on Rpc to use this HttpServer plugin? |
| items.ForEach(o => list.Add(o.ToPrimitive())); | ||
|
|
||
| return list.ToArray(); | ||
| } |
There was a problem hiding this comment.
If these methods are only used in plugins, it is recommended to put them in plugin extension methods.
There was a problem hiding this comment.
I can't do this using extension methods because I need to overload the method.
|
If we move RPC to plugin, I'm not sure will the |
|
They should be moved too. |
|
|
|
But will |
|
@shargon so what is the point of moving out with neo-types if it will still be inside neo (as dependency)? I believe it will only bring difficulty working with one more project, don't you think? |
|
@erikzhang sorry, I don't understand why this PR was closed, should I do something? |
|
This PR has not progressed for many days, and we need to move forward as soon as possible. So I removed RPC in #1340, and moved it to plugins: neo-project/neo-modules#160, neo-project/neo-modules#163 |
⚠I am not being able to push because of this file:
.github/workflows/dotnetcore.ymlcan you help me?!We are moving the RpcServer to a plugin as discussed on this PR: neo-project/neo-modules#143