Fix leveldb file increase #1333
Conversation
| @@ -162,6 +162,7 @@ protected override bool PreExecuteInstruction() | |||
| ApplicationEngine engine = new ApplicationEngine(TriggerType.Application, container, snapshot, extraGAS, testMode); | |||
| engine.LoadScript(script); | |||
| engine.Execute(); | |||
| engine.Dispose(); | |||
There was a problem hiding this comment.
The engine should be disposed by the caller.
There was a problem hiding this comment.
Seems most caller just call it one time without release, we need a way to fix it once for all.
(https://github.com/neo-project/neo-plugins/blob/29fee59944fb4ae3a9e8d644c3d334fd3df5b474/RpcNep5Tracker/RpcNep5Tracker.cs#L168)
Changing it in neo.dll could eliminate the hidden trouble.
Ortherwise, we need check all plugins who call it and refactor.
There was a problem hiding this comment.
You need to access the object, why dispose it before using?
There was a problem hiding this comment.
For most conditions, we just use the method to get the run results not engine itself.
Sometime the smartcontract may invoke needing more gas than the gas limit. If this happen when opening leveldb iterators, the engine interrupts and these iterators cannot close normally. Unless call engine "dispose" manually.
Seem gas limit interrupts may happen in many unpredictable situations, fix the hidden leak trouble here could nip in the bud.
Release file handles.Relate to neo-project/neo-modules#139