Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose ApplicationEngine after using (2.x) #1350

Merged
merged 3 commits into from
Dec 14, 2019
Merged

Dispose ApplicationEngine after using (2.x) #1350

merged 3 commits into from
Dec 14, 2019

Conversation

bettybao1209
Copy link
Contributor

No description provided.

@bettybao1209
Copy link
Contributor Author

update on neo-2.x based on PR #1336

shargon
shargon previously approved these changes Dec 11, 2019
View reviewed changes
erikzhang
erikzhang requested changes Dec 11, 2019
View reviewed changes
Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't use c# 8.0 features in the .NET Standard 2.0 projects.

@shargon shargon self-requested a review December 11, 2019 16:47
@shargon
Copy link
Member

shargon commented Dec 13, 2019 •
edited
Loading

It's not possible to re-launch travis on master 2x?

@erikzhang erikzhang merged commit d6c1862 into neo-project:master-2.x Dec 14, 2019
@bettybao1209 bettybao1209 deleted the fixes/dispose branch December 16, 2019 06:47
@nicolegys nicolegys mentioned this pull request Dec 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bettybao1209 @shargon @erikzhang