Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent abi changes without update the script #1577

Closed
wants to merge 1 commit into from
Closed

Prevent abi changes without update the script #1577

wants to merge 1 commit into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Apr 17, 2020 •
edited
Loading

Related to #1572 (comment)

@erikzhang
Copy link
Member

You can secretly modify anything without changing the scripthash, just by using dynamic calls. This has been discussed in #1481.

@shargon
Copy link
Member Author

shargon commented Apr 18, 2020

Better to have only one way, and not two 👼

@erikzhang
Copy link
Member

If someone updates the ABI without updating the script, there may be a mistake in the original ABI and he wants to fix it. We shouldn't stop him.

@shargon
Copy link
Member Author

shargon commented Apr 18, 2020

Then we should emit a notification when a abi or a contract it's created/updated/destroyed

@Tommo-L Tommo-L mentioned this pull request Jun 4, 2020
Merged
@erikzhang erikzhang closed this Jun 22, 2020
@shargon shargon deleted the check-abi-changes branch June 22, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shargon @erikzhang