[neox-2.x] add interop services #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #1419 |
|
If the main focus of the cross-chain in neo2 is the cross-chain with neo3, we must first make sure that we use the same encryption standards, I think we need at least Sha256 in both cases. |
We have |
|
Could you add UT for these methods? |
shargon
reviewed
Apr 22, 2020
shargon
reviewed
Apr 22, 2020
Unit Test will be added soon. |
shargon
reviewed
Apr 23, 2020
added 3 commits
April 24, 2020 11:10
Add recovery id in generate signature
shargon
reviewed
Apr 24, 2020
13 tasks
|
@shargon Can you review this again? |
Tommo-L
reviewed
Apr 27, 2020
Tommo-L
approved these changes
Apr 27, 2020
shargon
reviewed
Apr 27, 2020
shargon
reviewed
Apr 27, 2020
shargon
reviewed
Apr 27, 2020
added 2 commits
April 28, 2020 14:02
|
@shargon Can we merge this? |
shargon
reviewed
Apr 30, 2020
|
Ready to merge? |
shargon
approved these changes
May 6, 2020
Lichen9618
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 4/7 from
neo-ngd/neotoneox-2.xAdd 2 new interop services
Neo.Cryptography.Keccak256Neo.Cryptography.Ecrecover@erikzhang @shargon I reopen this. Please take a look.