Add EffectiveVoterTurnout

[erikzhang]

No description provided.

[erikzhang]

@neo-project/ngd-shanghai Test.

[vncoelho]

This gives more weight based on those who effective voted, right?

[vncoelho]

Who currently can edit these values MaxCommitteeMembersCount and MaxValidatorsCount?
They are set by default, right, on the protocol?
Perhaps we need also the Committee to vote for these values onchain, at least.

[erikzhang]

No one can edit these values. They are hard-coded.

[cloud8little]

Positive Scenarios
precondition:

protocol.json
{
  "ProtocolConfiguration": {
    "Magic": 111111,
    "MillisecondsPerBlock": 15000,
    "StandbyValidators": [
      "026a59b03f981a5dfded185472f4f19409cd229b5cfd11721e70f2b1d16079376a",
      "02c9d037722c4d0ca3037c589c387d45f13d00e489f974781d44793242ed8c1341"
    ],
    "ValidatorsCount": 1,
    "SeedList": [
    ]
  }
}

1. start CN, initial asset: 100,000,000 NEO; 30,000,000 GAS in multisignature address. get committee return the two public keys in protocol.json.

2. Single account vote for a candidate: register an account and prepare another account, transfer 100 neo, vote for the candidate. number of votes is 100.

3. Multiple accounts vote for a candidate: register an account to be candidate, and prepare two account, transfer 100/200 neo separately, vote for the candidate. number of votes is 100+200=300.
   

4. NEO change of the vote sender account: register an account to be candidate, and prepare two account A,B; transfer to A and B100/200 neo separately, vote for the candidate; then transfer from B to C 100 neo, number of votes is 200.
   

5. Change votes from one candidate to another candidate(CD1->CD2). Two candidates, CD1, A vote for 100; and B vote for CD2 200 votes, then account A vote for CD2; votes of CD1 is 0 now, votes of CD2 is 300 now.
   

6. When total votes of the candidates >= 20,000,000; the candidate with the highest votes become consensus. committee members are the new consensus public key and the candidate pub-key with secondary votes.

7. When total votes of the candidates >= 20,000,000 and there are two same highest votes; the candidate with smaller pubkey become consensus. and two pub-key become committee members.

8. When total votes of the candidates >= 20,000,000 and there are two same highest votes; the candidate with smaller pubkey become consensus, and then decrease total votes so that total votes < 20,000,000; then committee member become the two public keys in protocol.json.

9. unregister an account, and not change its sender neo balance. when register back, the votes is the same as before.

Negative Scenarios

1. no "ValidatorsCount" field in protocol.json
2. value of ValidatorsCount > length(StandbyValidators)