Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize IInventory serialization #1767

Closed

Conversation

shargon
Copy link
Member

@shargon shargon commented Jul 15, 2020

According to #1766 (comment)

This changes trying to avoid the re-serialization of IInventories when we send the same block or transaction that we receive previously.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@shargon shargon requested a review from Tommo-L July 15, 2020 07:58
Tommo-L
Tommo-L previously approved these changes Jul 16, 2020
@erikzhang
Copy link
Member

Is it worth optimizing?

@shargon
Copy link
Member Author

shargon commented Jul 16, 2020

@Tommo-L do you have any stadistic of how much can improve this PR?

I think that the cpu should be improved, because it reduce the serialization and compression close to 0, you will increase the memory, but I think that cpu it's more important in order to improve the tps.

@Tommo-L
Copy link
Contributor

Tommo-L commented Jul 16, 2020

We'll do a benchmark for this pr.

@shargon
Copy link
Member Author

shargon commented Aug 7, 2020

@Tommo-L any update?

@Tommo-L
Copy link
Contributor

Tommo-L commented Aug 11, 2020

We have done a test, but it wasn't much improvement. It is not recommended to add it. 😂

@erikzhang erikzhang closed this Aug 11, 2020
@shargon shargon deleted the optimize-invetory-serialization branch August 11, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants