Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exception Message For CreateContract #1787

Merged
merged 6 commits into from
Jul 22, 2020
Merged

Add Exception Message For CreateContract #1787

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1e23cd
Merge pull request #2 from neo-project/master
cloud8little Jul 20, 2020
b4438a1
Add Exception Message When Create Contract
cloud8little Jul 21, 2020
5c5462d
Merge branch 'master' into excpmsg_createcontract
shargon Jul 21, 2020
1b932d0
Add Exception Message
Qiao-Jin Jul 21, 2020
4a3dba6
Code optimization
Qiao-Jin Jul 21, 2020
7645d66
add UT
cloud8little Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/neo/SmartContract/ApplicationEngine.Contract.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ internal ContractState CreateContract(byte[] script, byte[] manifest)

UInt160 hash = script.ToScriptHash();
ContractState contract = Snapshot.Contracts.TryGet(hash);
if (contract != null) throw new InvalidOperationException();
if (contract != null) throw new InvalidOperationException("Contract Already Exists");
contract = new ContractState
{
Id = Snapshot.ContractId.GetAndChange().NextId++,
Script = script.ToArray(),
Manifest = ContractManifest.Parse(manifest)
};

if (!contract.Manifest.IsValid(hash)) throw new InvalidOperationException();
if (!contract.Manifest.IsValid(hash)) throw new InvalidOperationException("Invalid Manifest Hash");

Snapshot.Contracts.Add(hash, contract);
return contract;
Expand Down