Add node health #1811
Closed
Add node health #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2020 14:40
Tommo-L
reviewed
Aug 6, 2020
added 3 commits
August 13, 2020 14:17
shargon
reviewed
Aug 27, 2020
src/neo/Network/P2P/TaskManager.cs
Outdated
| @@ -243,8 +261,13 @@ private void OnTimer() | |||
| if (TimeProvider.Current.UtcNow - kvp.Value > TaskTimeout) | |||
| { | |||
| session.IndexTasks.Remove(kvp.Key); | |||
| session.TimeoutTimes++; | |||
| AssignSyncTask(kvp.Key, session); | |||
| if (++session.TimeoutTimes > 3) | |||
There was a problem hiding this comment.
We never reduce TimeoutTimes ? what's happend if at the begining we have two, in one day we have one, and in a week, we have another one, we terminate the session, and the node could be healthy, we should expire his bad rates.
There was a problem hiding this comment.
Yes, maybe we can reduce TimeoutTimes by one every day.
| else if (message_count > 1000) | ||
| { | ||
| message_count = 0; | ||
| if ((TimeProvider.Current.UtcNow - start_message_time).TotalMilliseconds < time_threshold) |
There was a problem hiding this comment.
We have a threshold for receive, but not for send, what happens if it's a normal behaviour be fast?
added 2 commits
August 31, 2020 17:37
Closed
|
@ShawnYun Are you still working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1679
Modified the weight calculation method.
The relevant parameters may need to be discussed.