Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Base58 Encode and Decode Interops on Neo #1833

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Implement Base58 Encode and Decode Interops on Neo #1833

merged 4 commits into from
Aug 14, 2020

Conversation

meevee98
Copy link
Contributor

@meevee98 meevee98 commented Aug 10, 2020 •
edited
Loading

Included two new interops:

  • System.Binary.Base58Encode
  • System.Binary.Base58Decode

Tommo-L
Tommo-L previously approved these changes Aug 11, 2020
View reviewed changes
@erikzhang
Copy link
Member

I will close this because it has been discussed and be denied in #263.

@erikzhang erikzhang closed this Aug 11, 2020
@meevee98
Copy link
Contributor Author

@erikzhang #263 is about the address conversion to script hash, that takes some other validations besides the base58 conversion.
In #1614 base58 syscall is listed as a desired feature

@Tommo-L
Copy link
Contributor

Tommo-L commented Aug 12, 2020

Base58 is not only used for addresses, but also can be used for contract. For example, one contract request a url, which returns base58 value.

@erikzhang erikzhang reopened this Aug 12, 2020
erikzhang
erikzhang previously approved these changes Aug 12, 2020
View reviewed changes
shargon
shargon previously approved these changes Aug 12, 2020
View reviewed changes
@shargon
Copy link
Member

shargon commented Aug 13, 2020

@meevee98 could you update the base branch?

@meevee98 meevee98 dismissed stale reviews from shargon and erikzhang via f1a3f1d August 13, 2020 15:15
@shargon shargon merged commit 55d8c51 into neo-project:master Aug 14, 2020
@shargon shargon mentioned this pull request Aug 14, 2020
Merged
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Aug 23, 2020
@roman-khimov
core/interop: add base58 encoding/decoding syscalls
9c72ea1 
Follow neo-project/neo#1833.
@ixje ixje mentioned this pull request Oct 13, 2020
Merged
@danwbyrne danwbyrne mentioned this pull request Dec 18, 2020
Closed
45 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 29, 2020
Closed
7 tasks
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@meevee98 @cloud8little
Implement Base58 Encode and Decode Interops on Neo (neo-project#1833)
dccc905 
* base58 encode and decode interop

* protected methods

* coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Tommo-L Tommo-L Tommo-L left review comments

@erikzhang erikzhang Awaiting requested review from erikzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meevee98 @erikzhang @Tommo-L @shargon