optimize LastSeenMessage #1834
Merged
optimize LastSeenMessage #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
previously approved these changes
Aug 11, 2020
|
In NEO3, the count of consensus nodes is fixed. So this is not needed, isn't it? |
What if validators changed. Still use previous record? |
erikzhang
reviewed
Aug 11, 2020
shargon
reviewed
Aug 11, 2020
Co-authored-by: Shargon <shargon@gmail.com>
vncoelho
reviewed
Aug 11, 2020
vncoelho
reviewed
Aug 11, 2020
vncoelho
reviewed
Aug 11, 2020
erikzhang
previously approved these changes
Aug 12, 2020
erikzhang
approved these changes
Aug 12, 2020
shargon
approved these changes
Aug 12, 2020
|
👍 |
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* optimize LastSeenMessage * rm log * use current height as default height * Update src/neo/Consensus/ConsensusContext.cs Co-authored-by: Shargon <shargon@gmail.com> * clean * Update ConsensusContext.cs * Optimize * Fix Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: erikzhang <erik@neo.org>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Fix 1834 * Fix UT * Remove useless condition Co-authored-by: Erik Zhang <erik@neo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply #1802 on
master.