[master-2.x] Force sync state root from all peers #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikzhang @shargon Can you review this? |
shargon
reviewed
Aug 24, 2020
| @@ -281,15 +286,11 @@ private void RequestTasks(TaskSession session) | |||
| var height = Blockchain.Singleton.Height; | |||
| if (state_height + 1 < height) | |||
| { | |||
| var state = Blockchain.Singleton.GetStateRoot((uint)(state_height + 1)); | |||
| if (state is null || state.Flag == StateRootVerifyFlag.Unverified) | |||
There was a problem hiding this comment.
After every block persisted, local state root will be calculated and persist into StateRoots with Unverified flag. Only check the block height is enough.
Line 656 in 95596f9
shargon
previously approved these changes
Aug 25, 2020
erikzhang
reviewed
Aug 31, 2020
shargon
approved these changes
Aug 31, 2020
|
I've already applied it on testnet seeds and all works well for more than a week. Root never stops sync again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix root sync slowly in
mast-2.x, especially many peers are2.10.3.