Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Designate contract #1950

Merged
merged 12 commits into from
Sep 23, 2020
Merged

Add Designate contract #1950

merged 12 commits into from
Sep 23, 2020

Conversation

ZhangTao1596
Copy link
Contributor

Add designate contract so that we can add more roles in the future.

  • Add DesignateContract
  • Move oracle node list from OracleContract to DesignateContract
  • Add StateValidator node list

@erikzhang @shargon @Tommo-L

vncoelho
vncoelho reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a good design for designating roles on the blockchain, such as the idea of running stateroots on other nodes.
Perhaps this is a good generic change even if we keep stateroort on CN.

@shargon
Copy link
Member

shargon commented Sep 22, 2020

I like the idea, it's more extensible.

@shargon shargon merged commit 98abed0 into neo-project:master Sep 23, 2020
@shargon shargon mentioned this pull request Sep 23, 2020
Merged
@ZhangTao1596 ZhangTao1596 deleted the designate-contract branch September 24, 2020 05:57
@roman-khimov roman-khimov mentioned this pull request Sep 29, 2020
Closed
@mialbu mialbu mentioned this pull request Nov 23, 2020
Closed
@danwbyrne danwbyrne mentioned this pull request Dec 18, 2020
Closed
45 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 29, 2020
Closed
17 tasks
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@ZhangTao1596 @shargon @erikzhang
Add Designate contract (neo-project#1950)
8424efa 
* add designate contract

* format

* fix

* Some checks

* reorganize file

* Remove empty line

* Update DesignateContract.cs

* ArgumentOutOfRangeException

* Update DesignateContract.cs

* Remove OracleContract.Lists.cs

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: erikzhang <erik@neo.org>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@ZhangTao1596 @shargon
@erikzhang @cloud8little
Add Designate contract (neo-project#1950)
8546f3c 
* add designate contract

* format

* fix

* Some checks

* reorganize file

* Remove empty line

* Update DesignateContract.cs

* ArgumentOutOfRangeException

* Update DesignateContract.cs

* Remove OracleContract.Lists.cs

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: erikzhang <erik@neo.org>
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 2, 2021
@ixje
https://github.com/neo-project/neo/pull/1950
664d8ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho left review comments

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhangTao1596 @shargon @erikzhang @vncoelho