Fix Witness limits #1958
Merged
Fix Witness limits #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neo-project/ngd-shanghai Test? |
| // Invocation = 11 * (64 + 2) = 726 | ||
| InvocationScript = reader.ReadVarBytes(744); | ||
| // Verification = m + (PUSH_PubKey * 21) + length + null + syscall = 1 + ((2 + 33) * 21) + 2 + 1 + 5 = 744 | ||
| VerificationScript = reader.ReadVarBytes(760); |
There was a problem hiding this comment.
These seem to be too perfectly calculated to me. I'd rather have some simpler values here like 2048 or 4096 so that we would have at least some reserve for the future.
There was a problem hiding this comment.
I don't have any strong opinion here. 2048 seems to be a bit more future-proof to me, but 1024 is already better than 744/760.
|
@neo-project/ngd-shanghai any update? |
erikzhang
approved these changes
Oct 3, 2020
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 7, 2020
45 tasks
12 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* Fix Witness max size * Fix comment * Fix comment * Change it to use constants * Changed to 1024 * Fix UT
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* Fix Witness max size * Fix comment * Fix comment * Change it to use constants * Changed to 1024 * Fix UT
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The committee signature (21/11) can't fit with the current limits.