Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wallet.MakeTransaction #2005

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix wallet.MakeTransaction #2005

merged 1 commit into from
Oct 15, 2020

Conversation

Tommo-L
Copy link
Contributor

@Tommo-L Tommo-L commented Oct 14, 2020

No description provided.

@Tommo-L Tommo-L mentioned this pull request Oct 14, 2020
Merged
@erikzhang
Copy link
Member

What's the difference?

@Qiao-Jin
Copy link
Contributor

What's the difference?

Currenty we use Base64 format instead of Hex for Transaction.script:

neo/src/neo/Network/P2P/Payloads/Transaction.cs

Line 274 in 6886991

json["script"] = Convert.ToBase64String(Script);

@shargon shargon merged commit 028f4b5 into neo-project:master Oct 15, 2020
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@Tommo-L
print script by base64 (neo-project#2005)
102e21b 
Co-authored-by: Tommo-L <luchuan@neo.org>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@Tommo-L @cloud8little
print script by base64 (neo-project#2005)
4d6365a 
Co-authored-by: Tommo-L <luchuan@neo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tommo-L @erikzhang @Qiao-Jin @shargon