-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-claim gas if it's needed #2008
Closed
+45
−12
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2cee028
Claim GAS before spend
shargon 14ee224
Optimize
shargon 2a29c0d
Rename
shargon a9e95ed
Allow to create tx
shargon 31ab7bd
Merge branch 'master' into allow-to-use-unclaimed-gas
shargon 8fb47bd
Reduce changes
shargon 3fedd30
Auto DistributeGas
shargon 6d8f941
Clean code
shargon 133eae9
Merge branch 'master' into allow-to-use-unclaimed-gas
shargon a89c9a3
Some fixes
shargon 3512d93
dotnet format
shargon 5484f82
Merge remote-tracking branch 'neo-project/master' into allow-to-use-u…
shargon 8a0825f
Merge remote-tracking branch 'neo-project/master' into allow-to-use-u…
shargon 85296c4
Merge branch 'master' into allow-to-use-unclaimed-gas
shargon d1b4d63
Fix merge
shargon 5300bdd
Merge branch 'master' into allow-to-use-unclaimed-gas
shargon faa698e
Add unclaimed gas
shargon 652e2c8
Other fix
shargon 973ab49
Fix
shargon bf68a21
Merge branch 'master' into allow-to-use-unclaimed-gas
shargon bfbb78b
Merge branch 'master' into allow-to-use-unclaimed-gas
shargon 8234327
Merge branch 'master' into allow-to-use-unclaimed-gas
shargon 3701664
Fixes
shargon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'master' into allow-to-use-unclaimed-gas
commit 133eae955a87bc73ea2668af1305721a17a0c543
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shargon, maybe it should only distributeGAS for the
tx.Sender
that needs it.In this sense, perhaps we could have a flag before
return balance + unclaimed >= fee;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, take a look again