Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize NextConsensus #2015

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Optimize NextConsensus #2015

merged 4 commits into from
Oct 27, 2020

Conversation

Qiao-Jin
Copy link
Contributor

@Qiao-Jin Qiao-Jin commented Oct 23, 2020 •
edited
Loading

Close #2014

@cloud8little
Copy link
Contributor

Test passed with #1848 . In block 10, voter vote to a new account with 2000,0000 votes, the validator update for consensus in block 13.
779da6ca270c0be95528ddf86952d56

and open the new account start consensus success.

shargon
shargon previously approved these changes Oct 23, 2020
View reviewed changes
@erikzhang
Copy link
Member

Where is it used?

@Tommo-L
Copy link
Contributor

Tommo-L commented Oct 26, 2020 •
edited
Loading

Where is it used?

The value of NextConseus is incorrent.

neo/src/neo/Consensus/ConsensusContext.cs

Line 380 in 6fc4161

NextConsensus = Blockchain.GetConsensusAddress(NativeContract.NEO.ComputeNextBlockValidators(Snapshot))

@erikzhang
Copy link
Member

Can you move this logic to ConsensusContext? Or just use GetNextBlockValidators().

@Qiao-Jin
Copy link
Contributor Author

Can you move this logic to ConsensusContext? Or just use GetNextBlockValidators().

Have moved logic to ConsensusContext

@erikzhang
Copy link
Member

Tested?

@cloud8little
Copy link
Contributor

Testing

@cloud8little
Copy link
Contributor

Testing

Test Passed. Good to merge.

@erikzhang erikzhang merged commit 7a58426 into neo-project:master Oct 27, 2020
@roman-khimov roman-khimov mentioned this pull request Oct 29, 2020
Closed
@fyrchik fyrchik mentioned this pull request Nov 10, 2020
Closed
@danwbyrne danwbyrne mentioned this pull request Dec 18, 2020
Closed
45 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 29, 2020
Closed
2 tasks
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@Qiao-Jin
Optimize NextConsensus (neo-project#2015)
aba20e0
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@Qiao-Jin @cloud8little
Optimize NextConsensus (neo-project#2015)
398a5be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consensus fail after updating validators
5 participants
@Qiao-Jin @cloud8little @erikzhang @Tommo-L @shargon