Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ContractFeatures #2060

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Remove ContractFeatures #2060

merged 3 commits into from
Nov 12, 2020

Conversation

erikzhang
Copy link
Member

  1. Removed ContractFeatures.HasStorage. In practice, all contracts require storage.
  2. Removed ContractFeatures.Payable. Now we should use onPayment method to replace it.

@erikzhang erikzhang mentioned this pull request Nov 12, 2020
Merged
@chenzhitong chenzhitong mentioned this pull request Nov 12, 2020
Merged
@erikzhang erikzhang merged commit 62a3ca2 into master Nov 12, 2020
@erikzhang erikzhang deleted the remove-payable branch November 12, 2020 14:45
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 13, 2020
@roman-khimov
smartcontract: remove contract features
286d918 
We're featureless now, all contracts have access to storage and payable status
is to be determined via new NEP. Follow neo-project/neo#2060.
@csmuller csmuller mentioned this pull request Nov 25, 2020
Closed
@luc10921 luc10921 mentioned this pull request Dec 1, 2020
Merged
@csmuller csmuller mentioned this pull request Dec 2, 2020
Closed
4 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 18, 2020
Closed
45 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 29, 2020
Closed
7 tasks
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@erikzhang
Remove ContractFeatures (neo-project#2060)
3f4fa11
@ixje ixje mentioned this pull request Jan 8, 2021
Closed
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@erikzhang @cloud8little
Remove ContractFeatures (neo-project#2060)
bc6b3c4
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 2, 2021
@ixje
https://github.com/neo-project/neo/pull/2060
1e98b99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikzhang @shargon @vncoelho