Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master-2.x] Add try-catch when receive a new tx #2066

Merged
merged 6 commits into from
Nov 20, 2020
Merged

[master-2.x] Add try-catch when receive a new tx #2066

merged 6 commits into from
Nov 20, 2020

Conversation

Tommo-L
Copy link
Contributor

@Tommo-L Tommo-L commented Nov 17, 2020

close #2065

@Tommo-L Tommo-L changed the title [master-x.] Fix tx References [master-2.x] Fix tx References Nov 17, 2020
shargon
shargon previously approved these changes Nov 17, 2020
View reviewed changes
@superboyiii
Copy link
Member

superboyiii commented Nov 18, 2020 •
edited
Loading

This way can cause data incompatible in histroy TXs.

@Tommo-L Tommo-L changed the title [master-2.x] Fix tx References [master-2.x] Add try-catch when receive a new tx Nov 19, 2020
@superboyiii
Copy link
Member

superboyiii commented Nov 20, 2020 •
edited
Loading

Works well on mainnet. It's compatible. #2065 and #1999 can be solved due to our test.

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Nov 20, 2020

Merge?

shargon
shargon reviewed Nov 20, 2020
View reviewed changes
neo/Ledger/Blockchain.cs Outdated Show resolved Hide resolved
@Tommo-L Tommo-L mentioned this pull request Nov 20, 2020
Merged
@shargon shargon merged commit 6e7c32a into neo-project:master-2.x Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tommo-L @superboyiii @shargon