Fix Oracle PostPersist #2074
Merged
Fix Oracle PostPersist #2074
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommo-L
reviewed
Nov 19, 2020
There was a problem hiding this comment.
Isn't it solved by
neo/src/neo/Network/P2P/Payloads/OracleResponse.cs
Lines 71 to 72 in a1590b0
Tommo-L
previously approved these changes
Nov 19, 2020
| if (oracle != null && | ||
| (!oracleRequests.TryGetValue(oracle.Id, out var hash) || hash != tx.Hash)) | ||
| { | ||
| return false; |
There was a problem hiding this comment.
BTW, this can be replaced with generic "Conflicts" mechanism (#1991) that would also allow for proper transaction to have higher priority over fallback.
erikzhang
reviewed
Nov 20, 2020
erikzhang
reviewed
Nov 24, 2020
erikzhang
reviewed
Nov 24, 2020
vncoelho
reviewed
Nov 24, 2020
|
UT failed |
erikzhang
reviewed
Nov 25, 2020
erikzhang
approved these changes
Nov 26, 2020
shargon
commented
Nov 26, 2020
| /// Store oracle responses | ||
| /// </summary> | ||
| private readonly Dictionary<ulong, UInt256> oracleResponses = new Dictionary<ulong, UInt256>(); | ||
|
|
||
| public void AddTransaction(Transaction tx) |
There was a problem hiding this comment.
Why don't remove CheckTransaction and Change Add to bool TryAdd (thread-safe)?
There was a problem hiding this comment.
Because CheckTransaction is called in Transaction.Verify().
|
Merge? |
45 tasks
5 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing an oracle’s response transaction, it is not verified that the transaction is successful which allows a group of oracle’s nodes to sign a transaction that will throw an exception in the
PostPersistmethod, causing a Denial of Service.Found by @Red4Sec