Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some class public to plugin #2109

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

ZhangTao1596
Copy link
Contributor

Make ByteArrayEqualityComparer StoreDataCache StoreMetaDataCache public to use in neo-project/neo-modules#414.

@ZhangTao1596 ZhangTao1596 changed the title Make some public to plugin Make some class public to plugin Nov 30, 2020
shargon
shargon previously approved these changes Nov 30, 2020
@erikzhang
Copy link
Member

Can you copy the code of ByteArrayEqualityComparer?

@ZhangTao1596
Copy link
Contributor Author

Can you copy the code of ByteArrayEqualityComparer?

Make StoreDataCache StoreMetaDataCache public and copy ByteArrayEqualityComparer ?

@erikzhang
Copy link
Member

Yes.

@ZhangTao1596
Copy link
Contributor Author

Yes.

Will do.

@ZhangTao1596
Copy link
Contributor Author

Yes.

Done.

@erikzhang erikzhang merged commit 8cd52df into neo-project:master Nov 30, 2020
@ZhangTao1596 ZhangTao1596 deleted the public-some branch December 1, 2020 02:06
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants