-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ManagementContract #2119
Conversation
I will fix the UT |
Please wait for me to complete the TODOs. Do you think this direction is okay? |
I think that it's simpler, the deploy method it was faster in the previous version, but as roman said in the meeting, the cost deserve because it's simpler. |
Yeah, it's good. |
Ready to review. @shargon Please fix the UTs. |
@neo-project/ngd-shanghai Can you test it? |
Why native contracts don't include |
Because they are native, they have magic. 🤣 |
If we include upgrade method in native contract now, then they could avoid storage conflict after upgrading, especially when we resync the histroy data in a new version. PS: I found it still can't solve this. |
We can include upgrade later, if it's necessary |
* Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com>
Every contract now has these and they're always invoked. See neo-project/neo#1913 and neo-project/neo#2119.
Follow neo-project/neo#2119 changes.
Follow neo-project/neo#2119 changes.
Follow neo-project/neo#2119 changes.
* Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj Co-authored-by: Shargon <shargon@gmail.com>
* Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj * Update name nep17 (#695) * Fix Parse manifestFilePath * merge master * Update Name for NEP17 * fix format * show error message * fix * fix Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: cloud8little <34291844+cloud8little@users.noreply.github.com>
* Final merge for Preview4 (#693) * Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj Co-authored-by: Shargon <shargon@gmail.com> * Merge from master (#697) * Sync to management SC (#689) * Sync to neo-project/neo#2119 * Update nuget Co-authored-by: Shargon <shargon@gmail.com> * Update to Neo v3.0.0-CI01105 (#692) * Update to Neo v3.0.0-CI01015 * Update neo-cli.csproj * Update name nep17 (#695) * Fix Parse manifestFilePath * merge master * Update Name for NEP17 * fix format * show error message * fix * fix Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: cloud8little <34291844+cloud8little@users.noreply.github.com> * Preview4 * sync gui * update changelog for preview 4 (#699) Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: cloud8little <34291844+cloud8little@users.noreply.github.com> Co-authored-by: Qiao Jin <43407364+Qiao-Jin@users.noreply.github.com>
utterly broken after this but not fixing until all preview + preview 5 changes are in
ManagementContract
, to manage all the contracts.ManagementContract
will check theirActiveBlockIndex
field.Contract.Create
,Contract.Update
, andContract.Destroy
to the native contract as methods.ContractState
andContractIdState
to the native contract as storage entries.Close #2000
Close #2056