Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce deploy fee #2153

Merged
merged 5 commits into from
Dec 17, 2020
Merged

Reduce deploy fee #2153

merged 5 commits into from
Dec 17, 2020

Conversation

Tommo-L
Copy link
Contributor

@Tommo-L Tommo-L commented Dec 16, 2020

Close #2151

Some discussion
#2140 (comment)
#2001

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Dec 16, 2020

In the future, we can raise it appropriately, and the threshold should be lowered in the early stage.

Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for other developers' comments. @neo-project/core @neo-project/ngd-seattle @neo-project/ngd-shanghai @roman-khimov

@devhawk
Copy link
Contributor

devhawk commented Dec 16, 2020

In the future, we can raise it appropriately, and the threshold should be lowered in the early stage.

Should it be configurable? (in the future, not for preview 4)

@superboyiii
Copy link
Member

superboyiii commented Dec 16, 2020

I agree with this.

Should it be configurable? (in the future, not for preview 4)

Yes, it should be configurable, after preview4.

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Dec 16, 2020

Should it be configurable? (in the future, not for preview 4)

@devhawk @superboyiii It's already configurable.

[ContractMethod(0_03000000, CallFlags.WriteStates)]
private void SetMinimumDeploymentFee(ApplicationEngine engine, BigInteger value)
{
if (value < 0) throw new ArgumentOutOfRangeException(nameof(value));
if (!CheckCommittee(engine)) throw new InvalidOperationException();
engine.Snapshot.Storages.GetAndChange(CreateStorageKey(Prefix_MinimumDeploymentFee)).Set(value);
}

@superboyiii
Copy link
Member

Prefix_MinimumDeploymentFee

Got it.

Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 is good for me.

Copy link
Member

@steven1227 steven1227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support on it.

@superboyiii
Copy link
Member

Merge?

@superboyiii
Copy link
Member

We could wait for a bit more hours for others. If no disagreement, I think it could be merged.

@erikzhang erikzhang merged commit 6add2eb into neo-project:master Dec 17, 2020
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestModeGas no longer big enough for contract deployment
8 participants