Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Callback APIs #2168

Merged
merged 3 commits into from
Dec 24, 2020
Merged

Remove Callback APIs #2168

merged 3 commits into from
Dec 24, 2020

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang erikzhang mentioned this pull request Dec 19, 2020
@erikzhang
Copy link
Member Author

We don't need callback APIs if we have #2169.

@vncoelho
Copy link
Member

we still would like to use some kind of callback like opeval.
Let's see.

@shargon
Copy link
Member

shargon commented Dec 20, 2020

If we remove the callbacks, we remove the possibility of doing lambda methods.

@erikzhang
Copy link
Member Author

We have Pointer.

@superboyiii superboyiii mentioned this pull request Dec 21, 2020
36 tasks
@erikzhang
Copy link
Member Author

Go?

@shargon
Copy link
Member

shargon commented Dec 22, 2020

We need to remove this line first

https://github.com/neo-project/neo-vm/blob/defb2371d9a6a032bdea94e0c8b903a4729c9152/src/neo-vm/ExecutionEngine.cs#L298

But a I am worry about share pointers. How we will be isolated?

@erikzhang
Copy link
Member Author

We need to remove this line first

Why should we remove this line? The Pointer should be used in the same contract only.

@shargon
Copy link
Member

shargon commented Dec 23, 2020

But then, how can we use a contract library with a method as an argument?

@erikzhang
Copy link
Member Author

But then, how can we use a contract library with a method as an argument?

You can send the method name to it, just like what we did in Oracle contract.

@erikzhang erikzhang merged commit d970bb9 into master Dec 24, 2020
@erikzhang erikzhang deleted the remove-callback-api branch December 24, 2020 14:45
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Jan 12, 2021
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants