Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Concat APIs #2170

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Remove Concat APIs #2170

merged 2 commits into from
Dec 22, 2020

Conversation

erikzhang
Copy link
Member

These APIs are dangerous because they can be nested and cause attacks. And no application scenarios of these APIs have been found.

@erikzhang erikzhang added this to the NEO 3.0 milestone Dec 19, 2020
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added here (#244) but I also agree that It can be avoided. @dicarlo2 do you have any use case?

@superboyiii superboyiii mentioned this pull request Dec 21, 2020
36 tasks
@erikzhang erikzhang merged commit c9df7a4 into master Dec 22, 2020
@erikzhang erikzhang deleted the remove-concat-api branch December 22, 2020 02:42
@spencercorwin
Copy link

@shargon You can tag myself or @danwbyrne in the future for stuff like this. We do use System.Iterator.Concat in our compiler but I think we can work around it being removed.

ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
roman-khimov pushed a commit to nspcc-dev/neo-go that referenced this pull request Jan 15, 2021
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants