Use ExtensiblePayload in consensus

[erikzhang]

No description provided.

[erikzhang]

Can someone fix the UT? I can't mock the consensus nodes in Blockchain.extensibleWitnessWhiteList.

[vncoelho]

I need to understand this concept of ExtensiblePayload.
I can try to fix, but may need some couple of days @erikzhang,3-5.

If someone can fix before it I can double check.

[vncoelho]

As far as I could investigate, @erikzhang, there is a problem with the RecoveryMessage.

Basically, I commented all tests...aehauheaue
But kept ConsensusService_SingleNodeActors_OnStart_PrepReq_PrepResponses_Commits, which checks a lot of things about the consensus flow.

There is something going on that CommitPayload is not being recovered.

[vncoelho]

I am sending the commit here and will keep uncommenting as soon as we advance.
For now, the debug should focus on making the commit payloads to be 3 after the recovery.

[vncoelho]

                    Console.WriteLine($"\nHI INSIDE RECOVERY IF ...{commitPayloads.Length}");
                    totalCommits = commitPayloads.Length;
                    foreach (ExtensiblePayload commitPayload in commitPayloads)
                        if (ReverifyAndProcessPayload(commitPayload)) validCommits++;
                    Console.WriteLine($"\nVALID COMMITS ...{validCommits}");    
                    
                     HI INSIDE RECOVERY IF ...4
 
                    VALID COMMITS ...0

Something is happening on ReverifyAndProcessPayload

line if (!payload.Verify(context.Snapshot)) return false; is returning false

[erikzhang]

neo/src/neo/Network/P2P/Payloads/ExtensiblePayload.cs

Line 95 in 83857d2

if (!Blockchain.Singleton.IsExtensibleWitnessWhiteListed(Sender)) return false;

The problem is that the mocked validators are not in the whitelist.

[shargon]

The problem is that the mocked validators are not in the whitelist.

I will try to add them with reflection

[shargon]

UT Fixed, we should create the module before merge it in order to test it well

[erikzhang]

UT Fixed, we should create the module before merge it in order to test it well

We can test it without creating module.

[vncoelho]

Such a beautiful work, great job @shargon.

[erikzhang]

@neo-project/ngd-shanghai Test?

[erikzhang]

I will start to create the module after merging this.

[shargon]

It's good for me, we can test it later