Automatically set Id for native contracts #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Jan 10, 2021
shargon
reviewed
Jan 10, 2021
|
|
||
| public static IReadOnlyCollection<NativeContract> Contracts { get; } = contractsList; | ||
| #region Named Native Contracts | ||
| public static ContractManagement ContractManagement { get; } = new ContractManagement(); |
There was a problem hiding this comment.
Maybe we can init this contracts inside the static constructor in order to avoid that the compiler optimizer play with us.
There was a problem hiding this comment.
Usually only partial classes have non-deterministic problems.
There was a problem hiding this comment.
I think that it's safer because this part is uncontrolled by us.
There was a problem hiding this comment.
But I don't want to modify every native contract each time we create a new one.
There was a problem hiding this comment.
Maybe if we use this code, we can avoid it?
[MethodImpl(MethodImplOptions.NoOptimization)]
static NativeContract() { }There was a problem hiding this comment.
It won't be any problem without this code.
shargon
previously approved these changes
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.