Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UT for PR#2215 #2220

Merged
merged 30 commits into from
Jan 14, 2021
Merged

Fix UT for PR#2215 #2220

merged 30 commits into from
Jan 14, 2021

Conversation

chenzhitong
Copy link
Member

@chenzhitong chenzhitong commented Jan 12, 2021 •
edited by shargon
Loading

Fix UT for PR #2215

  • IO/Caching/UT_DataCache.cs

  • IO/Caching/UT_CloneCache.cs

  • IO/UT_SerializableWrapper.cs

  • Ledger/UT_TransactionVerificationContext.cs

  • Ledger/UT_TrimmedBlock.cs

  • Network/P2p/Payloads/UT_Header.cs

  • Network/P2p/Payloads/UT_Transaction.cs

  • Persistence/UT_MemoryStore.cs

  • Persistence/UT_ReadOnlyView.cs

  • SmartContract/Native/UT_PolicyContract.cs

  • SmartContract/Native/UT_NeoToken.cs

  • SmartContract/UT_InteropPrices.cs

  • SmartContract/UT_InteropService.cs

  • SmartContract/UT_InteropService.NEO.cs

  • SmartContract/UT_SmartContractHelper.cs

  • SmartContract/UT_Syscalls.cs

  • UT_DataCache.cs

  • Wallets/UT_Wallet.cs

@chenzhitong
Copy link
Member Author

chenzhitong commented Jan 12, 2021 •
edited
Loading

SnapShotCache and DataCache removes the dynamic type, so how should it be used?
image

@chenzhitong chenzhitong mentioned this pull request Jan 12, 2021
Merged
@shargon
Copy link
Member

shargon commented Jan 12, 2021

I will help you

@chenzhitong
Copy link
Member Author

chenzhitong commented Jan 14, 2021 •
edited by shargon
Loading

Unit test result:
729 Passed
3 Failed

  • Neo.UnitTests.Ledger/UT_TrimmedBlock/TestGetBlock
  • Neo.UnitTests.SmartContract.Native/UT_NeoToken/Check_GetCommittee
  • Neo.UnitTests.SmartContract.Native/UT_NeoToken/TestCheckCandidate
  • Neo.UnitTests.SmartContract.Native/UT_NeoToken/TestClaimGas

@erikzhang erikzhang marked this pull request as ready for review January 14, 2021 08:35
@shargon
Copy link
Member

shargon commented Jan 14, 2021

Wait please, I need to recover TestBlockchain_GetTransactionHeight, it was removed

@erikzhang erikzhang merged commit e01bab6 into neo-project:native/ledger-contract Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenzhitong @shargon @erikzhang