Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AddService #2221

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Fix AddService #2221

merged 2 commits into from
Jan 13, 2021

Conversation

erikzhang
Copy link
Member

No description provided.

vncoelho
vncoelho reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallet as a service on the plugins?
I need to study this.

@erikzhang erikzhang mentioned this pull request Jan 13, 2021
Merged
3 tasks
@ZhangTao1596
Copy link
Contributor

ZhangTao1596 commented Jan 13, 2021 •
edited
Loading

We should stop service before remove or replace.
Why we need Remove and Replace? Why don't we just restart node?

@erikzhang erikzhang changed the title Allow remove/replace services Fix AddService Jan 13, 2021
@erikzhang erikzhang merged commit c5a0a72 into master Jan 13, 2021
@erikzhang erikzhang deleted the remove-service branch January 13, 2021 08:32
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@erikzhang @cloud8little
Fix AddService (neo-project#2221)
0f64fbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikzhang @ZhangTao1596 @vncoelho