Fix IPv4 and IPv6 Regex

[shargon]

Close #2283 close #2282

[erikzhang]

@roman-khimov Please review.

[erikzhang]

@roman-khimov

[roman-khimov]

This should work given that we're fine with not supporting uppercasing and IPv4 embeddeding in IPv6 address.

[erikzhang]

This should work given that we're fine with not supporting uppercasing and IPv4 embeddeding in IPv6 address.

Maybe we can support uppercase and convert to lowercase when storing?

[roman-khimov]

It depends on what kind of interface users of this do expect. At the moment it tends to be "we store syntactically-checked strings for you", so changing anything in user-provided data seems to be incorrect.

[erikzhang]

The convert should be done in a wallet/client.

[shargon]

We can support uppercase, but the RFC says this:

4.3.  Lowercase

   The characters "a", "b", "c", "d", "e", and "f" in an IPv6 address
   MUST be represented in lowercase.

[roman-khimov]

That's because RFC 5952 talks about output format, that is when 128 bits of IPv6 get converted to human-readable text output. It at the same time says that "all implementations MUST accept and be able to handle any legitimate [RFC4291] format" for the input part. We're accepting an address here.

[shargon]

That's because RFC 5952 talks about output format, that is when 128 bits of IPv6 get converted to human-readable text output. It at the same time says that "all implementations MUST accept and be able to handle any legitimate [RFC4291] format" for the input part. We're accepting an address here.

Then, it's ok to me accept uppercase too.

[erikzhang]

Then, it's ok to me accept uppercase too.

We should do it in wallet or client.