Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tokens in nns #2286

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Fix tokens in nns #2286

merged 2 commits into from
Feb 2, 2021

Conversation

bettybao1209
Copy link
Contributor

Methods returned in base class should be non-private.

@erikzhang
Copy link
Member

Why public?

@bettybao1209
Copy link
Contributor Author

bettybao1209 commented Feb 2, 2021 •
edited
Loading

Why public?

https://github.com/neo-project/neo/blob/master/src/neo/SmartContract/Native/NativeContract.cs#L61
For BindingFlags.NonPublic, only protected and internal methods on base classes are returned; private methods on base classes are not returned. Otherwise, we should use GetType().BaseType to find the base type.

@shargon shargon merged commit 6285ee1 into neo-project:master Feb 2, 2021
@bettybao1209 bettybao1209 deleted the fix-nns branch February 2, 2021 08:54
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 26, 2021
@ixje
https://github.com/neo-project/neo/pull/2286
bdc90c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bettybao1209 @erikzhang @shargon